-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the libtorch version mismatch issue #3086
fix the libtorch version mismatch issue #3086
Conversation
No ciflow labels are configured for this repo. |
I don't think simply changing to local_repository will solve the issue, since the locally installed torch in building wheel phase is still the latest nightly version. |
in the pre_build script I have uninstalled the latest nightly version, always use the version we have dependencies defined on py/requirements.txt However there is a new error in windows for cu118: I think we may have to anyway bump torchvision version from 0.19 to 0.20 and even though there is some test failures on batch_norm, it is acceptable and can be fixed later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-15 23:49:19.753876+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-15 23:49:38.292213+00:00
@@ -532,6 +532,6 @@
with enable_torchbind_tracing():
exp_program = torch.export.export(
module, tuple(arg_inputs), kwargs=kwarg_inputs, strict=False
)
- torch.export.save(exp_program, file_path)
\ No newline at end of file
+ torch.export.save(exp_program, file_path)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:05:49.326484+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:06:08.080367+00:00
@@ -532,6 +532,6 @@
with enable_torchbind_tracing():
exp_program = torch.export.export(
module, tuple(arg_inputs), kwargs=kwarg_inputs, strict=False
)
- torch.export.save(exp_program, file_path)
\ No newline at end of file
+ torch.export.save(exp_program, file_path)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:25:34.264305+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:25:54.988511+00:00
@@ -532,6 +532,6 @@
with enable_torchbind_tracing():
exp_program = torch.export.export(
module, tuple(arg_inputs), kwargs=kwarg_inputs, strict=False
)
- torch.export.save(exp_program, file_path)
\ No newline at end of file
+ torch.export.save(exp_program, file_path)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:27:06.573034+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2024-08-16 04:27:25.968256+00:00
@@ -532,6 +532,6 @@
with enable_torchbind_tracing():
exp_program = torch.export.export(
module, tuple(arg_inputs), kwargs=kwarg_inputs, strict=False
)
- torch.export.save(exp_program, file_path)
\ No newline at end of file
+ torch.export.save(exp_program, file_path)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
For the windows build issue, I am able to identify the issue is caused by the torchtrt.dll:
It is complaining the getinstance method in the UndefinedTensorImpl class
The procedure entry point
?getinstance@UndefinedTensorImpl@c10@@CAAEAU12@XZ
could not be located in the dynamic link library
C:\Users\lanl\git\venv_py310\Lib\site-packages\torch_tensorrt
lib\torchtrt.dll.
I believe this is related to the libtorch version:
currently we use the one from:
https://download.pytorch.org/libtorch/${CHANNEL}/${CU_VERSION}/libtorch-win-shared-with-deps-latest.zip
which is causing the issue.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: