fix: release/2.1 CI Repair
#2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-olive
added
the
WIP
github-actions
bot
added
component: api [Python]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gs-olive
force-pushed
the
ci_debug
branch
2 times, most recently
from
9dafca0 to
35a5887
Compare
gs-olive
commented
Dec 13, 2023
gs-olive
removed
the
WIP
narendasan
reviewed
Dec 19, 2023
| @@ -2,8 +2,8 @@ | |||
| set -eou pipefail | |||
| # Source conda so it's available to the script environment | |||
| source ${BUILD_ENV_FILE} | |||
| ${CONDA_RUN} ${PIP_INSTALL_TORCH} torchvision pyyaml | |||
| ${CONDA_RUN} ${PIP_INSTALL_TORCH} torch==2.1.2 torchvision==0.16.2 pyyaml | |||
There was a problem hiding this comment.
does this do anything? since theres already ${PIP_INSTALL_TORCH}?
There was a problem hiding this comment.
This is necessary, since in build-test.yml, when building Torch-TRT, we have:
PIP_INSTALL_TORCH='pip install torch==2.1.2 --extra-index-url https://download.pytorch.org/whl/test/cu118'
In linux-test.yml, when testing Torch-TRT using the artifact from build, we have:
PIP_INSTALL_TORCH='pip install torch --extra-index-url https://download.pytorch.org/whl/test/cu118'
The second one installs the 2.2.0.dev test build, which is the most up-to-date test build, but is incompatible with the version on which it was built. Specifying the version explicitly resolves this problem.
.github/workflows/linux-test.yml
Outdated
| @@ -66,6 +70,7 @@ jobs: | |||
| REF: ${{ inputs.ref }} | |||
| CU_VERSION: ${{ matrix.desired_cuda }} | |||
| SCRIPT: ${{ inputs.script }} | |||
| CHANNEL: ${{ inputs.channel }} | |||
There was a problem hiding this comment.
Does this do anything?
There was a problem hiding this comment.
Initially, I thought it would affect the PIP_INSTALL_TORCH command generated, but I will try omitting it and see how the CI performs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch==2.1.2for alignment with release version