feat: support for many padding dynamo converters#2482
Merged
Conversation
zewenli98
commented
Nov 23, 2023
gs-olive
reviewed
Nov 27, 2023
Collaborator
Author
|
Hi @gs-olive, thanks for your review! I just found out a better way to implement paddings, with the help of |
gs-olive
reviewed
Nov 27, 2023
c2b0a0d to
6530e57
Compare
6530e57 to
2e8c094
Compare
gs-olive
reviewed
Nov 29, 2023
gs-olive
left a comment
Contributor
There was a problem hiding this comment.
Overall looks great, added a few style comments and suggested modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for many padding dynamo converters, including:
Note:
torch.ops.aten._pad_circular.defaultliketorch.ops.aten.circular_pad1d.default, but according to PyTorch doc, it does have the similar functionality asreflectionandreplication, targeting for 2D, 3D, 4D, and 5D inputs.torch.ops.aten.pad.defaultis a higher-level function to call the other padding functions.Fixes #2461 #2211
Type of change
Checklist: