-
Notifications
You must be signed in to change notification settings - Fork 365
feat: support for many padding dynamo converters #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @gs-olive, thanks for your review! I just found out a better way to implement paddings, with the help of |
c2b0a0d
to
6530e57
Compare
6530e57
to
2e8c094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, added a few style comments and suggested modifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Support for many padding dynamo converters, including:
Note:
torch.ops.aten._pad_circular.default
liketorch.ops.aten.circular_pad1d.default
, but according to PyTorch doc, it does have the similar functionality asreflection
andreplication
, targeting for 2D, 3D, 4D, and 5D inputs.torch.ops.aten.pad.default
is a higher-level function to call the other padding functions.Fixes #2461 #2211
Type of change
Checklist: