chore: Switch to new export apis #2376

peri044 · 2023-10-09T20:21:47Z

Description

Move to new dynamic shapes API which accepts dynamic shapes for each Input via names.
Add name attribute for torch_tensorrt.Input which is only used for dynamo tracing.
Remove constraints API calls
Remove unittest patching and use run_decompositions API.

Type of change

Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

gs-olive

This looks good to me, pending CI

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive

Overall looks good - added some questions on the name parameter

py/torch_tensorrt/_Input.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/_exporter.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

gs-olive

Looks good to me - added a minor documentation comment/question

py/torch_tensorrt/_Input.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/_Input.py

py/torch_tensorrt/dynamo/_exporter.py

py/torch_tensorrt/dynamo/_tracer.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

chore: Switch to new export apis

d06c74a

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

facebook-github-bot added the cla signed label Oct 9, 2023

github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 9, 2023

github-actions bot requested a review from gs-olive October 9, 2023 20:22

chore: rebase with main

47e0997

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Oct 9, 2023

View reviewed changes

gs-olive approved these changes Oct 9, 2023

View reviewed changes

Merge branch 'main' into export_2.2

fd29fe0

github-actions bot approved these changes Oct 11, 2023

View reviewed changes

feat: Add support for dynamic shapes and remove constraints API

ad3b031

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot added the component: tests Issues re: Tests label Oct 19, 2023

github-actions bot approved these changes Oct 19, 2023

View reviewed changes

chore: rebase with main

6e19330

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 15, 2023

View reviewed changes

gs-olive reviewed Nov 15, 2023

View reviewed changes

py/torch_tensorrt/_Input.py Show resolved Hide resolved

chore: updates

2d09249

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 16, 2023

View reviewed changes

chore: isolate serde tests in a separate job

d58bc5d

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 17, 2023

View reviewed changes

peri044 added 2 commits November 17, 2023 16:56

chore: fix output node

bc7eaa3

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: fix export serde tests

ab92f25

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 20, 2023

View reviewed changes

chore: fix tests

7a0d7bb

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 20, 2023

View reviewed changes

gs-olive reviewed Nov 27, 2023

View reviewed changes

py/torch_tensorrt/dynamo/_exporter.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/_exporter.py Show resolved Hide resolved

chore: remove redundant comments

8903382

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 28, 2023

View reviewed changes

gs-olive approved these changes Nov 29, 2023

View reviewed changes

py/torch_tensorrt/_Input.py Outdated Show resolved Hide resolved

chore: edit docstring

0db5235

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Nov 30, 2023

View reviewed changes

narendasan reviewed Dec 1, 2023

View reviewed changes

py/torch_tensorrt/_Input.py Show resolved Hide resolved

py/torch_tensorrt/dynamo/_exporter.py Show resolved Hide resolved

py/torch_tensorrt/dynamo/_exporter.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/_tracer.py Outdated Show resolved Hide resolved

chore: address review comments

b78fe7a

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 4, 2023

View reviewed changes

chore: fix kwargs in tracer

4df8f6d

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 4, 2023

View reviewed changes

chore: tracer inputs check

536cbe6

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 4, 2023

View reviewed changes

chore: Update test case export utilities

073b3e2

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 5, 2023

View reviewed changes

chore: disable test_hybrid_conv_fallback

282339b

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 5, 2023

View reviewed changes

peri044 merged commit bc6e1fa into main Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Switch to new export apis #2376

chore: Switch to new export apis #2376

peri044 commented Oct 9, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

gs-olive left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

gs-olive left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

gs-olive left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

chore: Switch to new export apis #2376

chore: Switch to new export apis #2376

Conversation

peri044 commented Oct 9, 2023 • edited Loading

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

peri044 commented Oct 9, 2023 •

edited

Loading