[fix] aten::stack with dynamic inputs #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
peri044
reviewed
Apr 6, 2023
| auto shuffle_layer = ctx->net->addShuffle(*itensor); | ||
| TORCHTRT_CHECK(shuffle_layer, "Unable to create shuffle layer from node: " << *n); | ||
| shuffle_layer->setReshapeDimensions(util::unsqueezeDims(itensor->getDimensions(), dim)); | ||
| shuffle_layer->setReshapeDimensions(util::unsqueezeDims(itensor->getDimensions(), dim, 1, false)); |
There was a problem hiding this comment.
In the description of this PR, it says Unsqueezed dims used 0 for dynamic dimension which was not aligned correctly with the dynamic dim in the input, switch to using -1.. Here the val is 1 (which is typical of an unsqueeze op). Can you elaborate on what's going on here related to dynamic shapes?
There was a problem hiding this comment.
I'm referring to the last arg to unsqueezeDims use_zeros which previously defaulted to true and converted dynamic dimensions to 0 rather than -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves error preventing aten::stack from converting correctly with dynamic shapes. Unsqueezed dims used 0 for dynamic dimension which was not aligned correctly with the dynamic dim in the input, switch to using -1.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: