Addressing review comments

Author: apbose

py/torch_tensorrt/dynamo/conversion/impl/cat.py

@@ -1,11 +1,16 @@
 from typing import Dict, Optional, Sequence, Union
 
+import numpy as np
 import torch
 from torch.fx.node import Target
 from torch_tensorrt.dynamo._SourceIR import SourceIR
-from torch_tensorrt.fx.converters.converter_utils import set_layer_name
 from torch_tensorrt.dynamo.conversion._ConversionContext import ConversionContext
-from torch_tensorrt.dynamo.conversion.converter_utils import get_trt_tensor
+from torch_tensorrt.dynamo.conversion.converter_utils import (
+    SourceIR,
+    get_positive_dim,
+    get_trt_tensor,
+)
+from torch_tensorrt.fx.converters.converter_utils import set_layer_name
 from torch_tensorrt.fx.types import TRTNetwork, TRTTensor
 
 
@@ -14,15 +19,16 @@ def cat(
     target: Target,
     source_ir: Optional[SourceIR],
     name: str,
-    input: Union[TRTTensor, Sequence[TRTTensor]],
+    input: Sequence[Union[TRTTensor, torch.Tensor, np.ndarray]],
     dim: int,
 ) -> Union[TRTTensor, Sequence[TRTTensor]]:
+    trt_inputs = []
     for each_input in input:
-        if(not isinstance(each_input, TRTTensor)):
-            each_input = get_trt_tensor(each_input)
-    concat_layer = ctx.net.add_concatenation(input)
-    if dim < 0:
-        dim = len(input[0].shape) + dim
+        if not isinstance(each_input, TRTTensor):
+            each_input = get_trt_tensor(ctx, each_input, name + "_tensor_{i}")
+        trt_inputs.append(each_input)
+    concat_layer = ctx.net.add_concatenation(trt_inputs)
+    dim = get_positive_dim(dim, len(input[0].shape))
 
     concat_layer.axis = dim
     set_layer_name(concat_layer, target, name + "_gather", source_ir)