Skip to content

fix(404): navbar not cover 404 content anymore #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

rwiteshbera
Copy link
Contributor

@rwiteshbera rwiteshbera commented Oct 5, 2021

A (1)

Now navbar will not cover the h1 tag.

fix #180

What is the purpose of this pull request?

  • Bug fix

@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 43f18b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/615c34aad969350008826b8a

😎 Browse the preview: https://deploy-preview-184--code-generator.netlify.app/

@vfdev-5 vfdev-5 requested a review from ydcjeff October 5, 2021 09:00
@vfdev-5
Copy link
Member

vfdev-5 commented Oct 5, 2021

@rwiteshbera thanks for the PR and the fix ! LGTM, I let @trsvchn or @ydcjeff merge it

@ydcjeff ydcjeff changed the title Fixed the h1 tag "404 not found" fix(404): navbar not cover 404 content anymore Oct 5, 2021
@ydcjeff ydcjeff merged commit c0a3b15 into pytorch-ignite:main Oct 5, 2021
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rwiteshbera ! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix nav bar in 404 page
4 participants