add Gemini LLM integration #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lecheel
commented
Feb 28, 2025
lecheel
commented
- Implements the `Xai` struct and `LLM` trait for interacting with the X.AI API. - Includes error handling for missing API key. - Supports streaming responses and termination.
- Implements the `Gemini` struct and `LLM` trait for interacting with the Gemini API. - Includes error handling for missing API key. - Supports streaming responses and termination.
- Remove Xai LLM backend - Remove xai config
pythops
reviewed
Mar 1, 2025
- Uncomment release profile settings - Enable LTO, stripping, and single codegen unit
pythops
reviewed
Mar 16, 2025
src/gemini.rs
Outdated
Comment on lines
16
to
21
| // Configuration file example | ||
| // | ||
| // [gemini] | ||
| // base_url = "https://generativelanguage.googleapis.com/v1beta/models" | ||
| // model = "gemini-2.0-flash" | ||
| // |
pythops
reviewed
Mar 16, 2025
src/gemini.rs
Outdated
Comment on lines
200
to
206
| let body: Value = json!({ | ||
| "contents": contents, | ||
| "generationConfig": { | ||
| "temperature": 0.7, | ||
| "topK": 32, | ||
| "topP": 0.95, | ||
| "maxOutputTokens": 8192 |
There was a problem hiding this comment.
maybe we should put that somewhere where it can be configured 🤔 what do you think ?
There was a problem hiding this comment.
i think which depend on entire proj to provide the configured option, in gemini without this also work fine. yes the comment can be removed just the reference for correct url in config.toml
|
@lecheel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.