Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

로그인을 하기 전에도, retrieveMySponsorProposal()가 불러집니다. #137

Open
minho4yang opened this issue May 30, 2019 · 2 comments
Open

로그인을 하기 전에도, retrieveMySponsorProposal()가 불러집니다. #137

minho4yang opened this issue May 30, 2019 · 2 comments

Comments

@minho4yang
Copy link

  1. /pages/_app.tsx componentDidMount() call this.sponsorStore.initialize()
    https://github.com/pythonkr/pyconkr-web/blob/develop/pages/_app.tsx#L102-L115

  2. /lib/stores/Sponsor/SponsorStore.ts initialize() call this.retrieveMySponsorProposal()
    https://github.com/pythonkr/pyconkr-web/blob/develop/lib/stores/Sponsor/SponsorStore.ts#L58-L63

  3. /lib/stores/Sponsor/SponsorStore.ts retrieveMySponsorProposal() call getMySponsor(client) without any check.
    https://github.com/pythonkr/pyconkr-web/blob/develop/lib/stores/Sponsor/SponsorStore.ts#L89-L92
@minho4yang
Copy link
Author

getMySponsor() 는 로그인 없이는 실패할 것이기 때문에, api서버에 부담을 줍니다.

@minho4yang
Copy link
Author

related with pythonkr/pyconkr-2019-api#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minho4yang