Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have minimum words in the public comment #533

Open
kracekumar opened this issue Jun 19, 2017 · 9 comments · May be fixed by #537
Open

Have minimum words in the public comment #533

kracekumar opened this issue Jun 19, 2017 · 9 comments · May be fixed by #537

Comments

@kracekumar
Copy link
Member

Like Stack Overflow, implement minimum words for a comment. The good count is 15 words.

@sivaa
Copy link
Contributor

sivaa commented Jun 23, 2017

@kracekumar Are you referring to minimum chars?

@kracekumar
Copy link
Member Author

@sivaa Oh, yes. But 15 characters is low but can be configurable.

@prakharchoudhary
Copy link

@kracekumar I am new to open source and would like to contribute to this project. Can I work on this issue?

@ChillarAnand
Copy link
Member

Please go ahead @prakharchoudhary

@kracekumar
Copy link
Member Author

@prakharchoudhary We'd love to have new contributors. Like @ChillarAnand said, please go ahead and start the work.

  1. The check needs to be in both client and server side.
  2. The UI should display a minimum number of required words before the user starts typing.

Feel free to discuss, doubts, and your plan.

@prakharchoudhary
Copy link

prakharchoudhary commented Jun 29, 2017

@kracekumar I have added the required changes locally. However, Flake8 keeps giving me errors for star-imports in files like .settings/dev.py. So should I correct them or ignore them before making my PR?

@RishabhJain2018
Copy link
Contributor

@prakharchoudhary Use # noqa: ignore=F405 as a comment in star imports line to ignore flake8.

This was referenced Jun 30, 2017
@onlinejudge95
Copy link

Hey guys, what is the status of this issue. Willing to take it up if required.

@zerothabhishek
Copy link
Contributor

Hey @onlinejudge95, the PR #537 has been already submitted for this. We can test it ourselves, and merge if it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants