Skip to content

Commit e2e5201

Browse files
DaniPopesemhane
andauthored
chore(deps): bump enr, discv5, secp256k1 (#7000)
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
1 parent 3ad3bbc commit e2e5201

File tree

18 files changed

+169
-270
lines changed

18 files changed

+169
-270
lines changed

Cargo.lock

Lines changed: 28 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -272,13 +272,8 @@ reth-trie-parallel = { path = "crates/trie-parallel" }
272272
reth-node-events = { path = "crates/node/events" }
273273

274274
# revm
275-
revm = { version = "8.0.0", features = [
276-
"std",
277-
"secp256k1",
278-
], default-features = false }
279-
revm-primitives = { version = "3.1.0", features = [
280-
"std",
281-
], default-features = false }
275+
revm = { version = "8.0.0", features = ["std", "secp256k1"], default-features = false }
276+
revm-primitives = { version = "3.1.0", features = ["std"], default-features = false }
282277
revm-inspectors = { git = "https://github.com/paradigmxyz/evm-inspectors", rev = "dc614ee" }
283278

284279
# eth
@@ -359,7 +354,7 @@ http = "0.2.8"
359354
http-body = "0.4.5"
360355

361356
# p2p
362-
discv5 = { git = "https://github.com/sigp/discv5", rev = "04ac004" }
357+
discv5 = "0.6.0"
363358
igd-next = "0.14.3"
364359

365360
# rpc
@@ -368,11 +363,12 @@ jsonrpsee-core = "0.22"
368363
jsonrpsee-types = "0.22"
369364

370365
# crypto
371-
secp256k1 = { version = "0.27.0", default-features = false, features = [
366+
secp256k1 = { version = "0.28", default-features = false, features = [
372367
"global-context",
373368
"recovery",
374369
] }
375-
enr = { version = "=0.10.0", default-features = false, features = ["k256"] }
370+
# TODO: Remove `k256` feature: https://github.com/sigp/enr/pull/74
371+
enr = { version = "0.12.0", default-features = false, features = ["k256", "rust-secp256k1"] }
376372

377373
# for eip-4844
378374
c-kzg = "1.0.0"

crates/interfaces/src/test_utils/generators.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use reth_primitives::{
66
proofs, sign_message, Account, Address, BlockNumber, Bytes, Header, Log, Receipt, SealedBlock,
77
SealedHeader, StorageEntry, Transaction, TransactionSigned, TxKind, TxLegacy, B256, U256,
88
};
9-
use secp256k1::{KeyPair, Secp256k1};
9+
use secp256k1::{Keypair, Secp256k1};
1010
use std::{
1111
cmp::{max, min},
1212
collections::{hash_map::DefaultHasher, BTreeMap},
@@ -91,22 +91,22 @@ pub fn random_tx<R: Rng>(rng: &mut R) -> Transaction {
9191
/// - There is no guarantee that the nonce is not used twice for the same account
9292
pub fn random_signed_tx<R: Rng>(rng: &mut R) -> TransactionSigned {
9393
let secp = Secp256k1::new();
94-
let key_pair = KeyPair::new(&secp, rng);
94+
let key_pair = Keypair::new(&secp, rng);
9595
let tx = random_tx(rng);
9696
sign_tx_with_key_pair(key_pair, tx)
9797
}
9898

9999
/// Signs the [Transaction] with the given key pair.
100-
pub fn sign_tx_with_key_pair(key_pair: KeyPair, tx: Transaction) -> TransactionSigned {
100+
pub fn sign_tx_with_key_pair(key_pair: Keypair, tx: Transaction) -> TransactionSigned {
101101
let signature =
102102
sign_message(B256::from_slice(&key_pair.secret_bytes()[..]), tx.signature_hash()).unwrap();
103103
TransactionSigned::from_transaction_and_signature(tx, signature)
104104
}
105105

106-
/// Generates a set of [KeyPair]s based on the desired count.
107-
pub fn generate_keys<R: Rng>(rng: &mut R, count: usize) -> Vec<KeyPair> {
106+
/// Generates a set of [Keypair]s based on the desired count.
107+
pub fn generate_keys<R: Rng>(rng: &mut R, count: usize) -> Vec<Keypair> {
108108
let secp = Secp256k1::new();
109-
(0..count).map(|_| KeyPair::new(&secp, rng)).collect()
109+
(0..count).map(|_| Keypair::new(&secp, rng)).collect()
110110
}
111111

112112
/// Generate a random block filled with signed transactions (generated using
@@ -404,7 +404,7 @@ mod tests {
404404
let signature_hash = tx.signature_hash();
405405

406406
for _ in 0..100 {
407-
let key_pair = KeyPair::new(&secp, &mut rand::thread_rng());
407+
let key_pair = Keypair::new(&secp, &mut rand::thread_rng());
408408

409409
let signature =
410410
sign_message(B256::from_slice(&key_pair.secret_bytes()[..]), signature_hash)

crates/net/discv4/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ reth-net-nat.workspace = true
2121
alloy-rlp = { workspace = true, features = ["derive"] }
2222
discv5.workspace = true
2323
secp256k1 = { workspace = true, features = ["global-context", "rand-std", "recovery", "serde"] }
24-
enr = { workspace = true, default-features = false, features = ["rust-secp256k1"] }
25-
rlp = "0.5" # needed for enr
24+
enr.workspace = true
2625
# async/futures
2726
tokio = { workspace = true, features = ["io-util", "net", "time"] }
2827
tokio-stream.workspace = true

crates/net/discv4/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ use discv5::{
3939
};
4040
use enr::Enr;
4141
use parking_lot::Mutex;
42-
use proto::{EnrRequest, EnrResponse, EnrWrapper};
42+
use proto::{EnrRequest, EnrResponse};
4343
use reth_primitives::{bytes::Bytes, hex, ForkId, PeerId, B256};
4444
use secp256k1::SecretKey;
4545
use std::{
@@ -1279,7 +1279,7 @@ impl Discv4Service {
12791279
self.send_packet(
12801280
Message::EnrResponse(EnrResponse {
12811281
request_hash,
1282-
enr: EnrWrapper::new(self.local_eip_868_enr.clone()),
1282+
enr: self.local_eip_868_enr.clone(),
12831283
}),
12841284
remote_addr,
12851285
);

0 commit comments

Comments
 (0)