feat(window): add kwargs to open_window #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eruvanos merged 1 commit into development from open_window_kwargs

Jul 31, 2024

Member

eruvanos commented Jul 29, 2024 •

edited

Loading

Do you think it is fine to add kwargs to the open_window? this would allow things like fullscreen etc


          feat(window): add kwargs to open_window

73ac6ef

eruvanos requested a review from einarf

July 29, 2024 18:41

Member

einarf commented Jul 30, 2024

Definitely reasonable.

einarf approved these changes

View reviewed changes

eruvanos merged commit 5751f52 into development

8 checks passed

eruvanos deleted the open_window_kwargs branch

July 31, 2024 18:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet