Skip to content

Unify text input events onto a base class and rename UITextEvent #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jul 25, 2024

  • Rename UITextEvent to less misleading UITextInputEvent
  • Add a UITextEvent baseclass as in mouse events
    • Instead of holding data, it allows responding to text input field events
    • It holds no data, but that's okay
  • Document what UITextInputEvent actually does with a link to pyglet

Intersphinx is being annoying and my local Sphinx is acting up, so I'm linking the ugly way for now since it helps ship 3.0 faster.

@pushfoo pushfoo requested a review from eruvanos July 25, 2024 18:10
@eruvanos eruvanos merged commit eb85958 into development Jul 25, 2024
8 checks passed
@eruvanos eruvanos deleted the text-event-updates branch July 25, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants