Skip to content

Fix platforms.deleter + add tests for physics behavior properties #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2024
Merged

Fix platforms.deleter + add tests for physics behavior properties #2166

merged 3 commits into from
Jun 30, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jun 30, 2024 •
edited
Loading

TL;DR: Make sure we aren't actually replacing instance lists unintentionally

  • Make platforms.deleter use list.clear like the rest
  • Add tests for this behavior for both PhysicsEngineSimple and PhysicsEnginePlatformer
  • Explain the behavior in the tests

@pushfoo pushfoo changed the title Fix setting instead of clearing in platforms.deleter Fix platforms.deleter + add tests for physics behavior properties Jun 30, 2024
@pushfoo pushfoo merged commit 0c91ec4 into pythonarcade:development Jun 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pushfoo