Skip to content

Partial fix for PDF doc build #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 4, 2024

TL;DR: replaced 403ing images + added gif converter, but LaTex still broken

Changes

  • Replaced missing (403) links starting with camo.githubusercontent
    • When screenshots were available, I used those
    • For when they weren't, there's a pngcrushed placeholder image
  • Added imageconvert extension for PDF to convert gifs
  • Cleaned up Boxhead Survivor sampel game links + made them clickable
  • Added LaTeX build requirements notes

What's Still Broken / Untested

PDF Build: Still Broken

Running ./make.py latexpdf produces plenty of warnings and ends with this error and a LaTeX input prompt:

LaTeX Warning: Hyper reference `tutorials/platform_tutorial/index:platformer-tu
torial' on page 67 undefined on input line 2403.

[67 <./YI7uLX.jpg>] [68 <./screenshot1.png>]
Runaway argument?
{{example
! Paragraph ended before \\sphinxsafeincludegraphics was complete.
<to be read again> 
                   \par 
l.2483 
       
? 

EPUB build: Untested

Haven't gotten to this yet.

@pushfoo
Copy link
Member Author

pushfoo commented Apr 4, 2024

The test failures appear to be pyright upset about the GUI.

@pushfoo pushfoo force-pushed the fix_doc_build_image_403s branch from 0406a93 to 05b01f7 Compare April 11, 2024 14:19
@pushfoo pushfoo requested a review from pvcraven April 11, 2024 17:29
@pushfoo pushfoo force-pushed the fix_doc_build_image_403s branch from da450f9 to 587c4fc Compare April 16, 2024 00:34
@pushfoo
Copy link
Member Author

pushfoo commented Apr 16, 2024

Rebased onto development to include #2062.

@einarf einarf merged commit d625a01 into pythonarcade:development Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants