-
Notifications
You must be signed in to change notification settings - Fork 343
Switch to Pyglet 2.1 or dev releases #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: Looks like CI failures are all unimportant but annoying type annotation issues. In addition to pre-existing CI failures from the GUI, we also gain a few new ones due to 2.1 changes on pyglet's side:
|
Ben just shipped pyglet 2.1dev2. I plan on updating this branch to that after I get back in < 2 hrs. |
The recent commits:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Get new pyglet bug fixes + immutable vecs for #2021
Why?
Per Discord discussion with @Cleptomania, this change:
BasicSprite.scale
behavior in Name scale properties on Sprites to things that make sense #2021:Changes
pyglet==2.1dev2
pyglet.canvas
to refer topyglet.display
Testing Steps Taken
Human spot-check of examples (GUI, Text, and Media) on
Run unit & integration tests on
Follow-up Work
BasicSprite
changes