Swizzle support for colors #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
requested changes
Feb 27, 2024
There was a problem hiding this comment.
This is almost ready. I think the current implementation is faster and easier than __getattribute__ hacks, even if color_instance.brga would be cleaner code.
Changes I'd like:
- Use
ValueErrorinsteaad ofException - Consider mentioning the offending value in the exception
- Add tests
Add basic swizzle tests w/o itertools
Add doc for swizzle + edge case to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We talked about this in the Discord once. And why not, right? It's a cheap function to write.
Could probably have docs or something!
Takes a string of r, g, b, and a's and returns a tuple of those properties in order.
It's an OpenGL thing.