typing(sprites): enhance typings on Sprite and SpriteList #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Thank you for taking a look at this, and I apologize for the delay in reviewing it.
tl;dr I think the physics engine changes are fine, but I have concerns about the use of Literal, the type aliases created with it, and the performance impacts of the alternatives.
I'd spend more time looking at ArcadeContext and gl.Context to better understand blend functions and our current implementations of them.
If you've got Discord, feel free to join the server and bring these changes up in #arcade-dev-1.
Snipy7374
pushed a commit
to Snipy7374/arcade
that referenced
this pull request
Sep 8, 2023
* Fixed PyRight issues. The latest version of PyRight is a little over zealous.. There where two flagged non-issues. One where it didn't realise that the code would escape early, and another which is all pyglets fault. * initial commit for doc_stack/fix_readthedocs * Tell readthedocs to install `dev` dependencies, same as CI. Keeps things consistent * Update index.rst Dropdowm -> Dropdown 2 times * upgrade sphinx * Fix rendering issue in CONTRIBUTING.rst * Revert erroneous dep upgrade from pythonarcade#1826 * Lock pyright version To avoid CI breakages due to pyright releasing a new version, not caused by any of our code * oof python versions * add pending comment * Make `_move_sprite()` generic * Fix exception type when Window.show_view is passed a non-View (pythonarcade#1876) * Fix exception type when Window.show_view is passed a non-View * Include instance info in Window.show_view TypeError * Add check for TypeError from show_view in Window tests * Revert inclusion of full printout in show_view TypeError * Update build procedure (pythonarcade#1884) * Make annotations singular * Move filter & blend aliases to arcade.gl.types * Use PyGLenum per @cspotcode's suggestion * Remove use of literals * Move to arcade.gl.types * Import TypeAlias from typing_extensions since it's from 3.10 * Remove | assignment incompatible with 3.8 * Allow using either int or Tuple[int, int] for filter in SpriteList.draw * Add casts to make pyright happy --------- Co-authored-by: DragonMoffon <happydog.aja@gmail.com> Co-authored-by: cspotcode <cspotcode@gmail.com> Co-authored-by: Dominik <dominik.reinartz@hotmail.com> Co-authored-by: DragonMoffon <86714785+DragonMoffon@users.noreply.github.com> Co-authored-by: Paul V Craven <paul@cravenfamily.com>
* Use PyGLenum per @cspotcode's suggestion * Remove use of literals * Move to arcade.gl.types * Import TypeAlias from typing_extensions since it's from 3.10
Snipy7374
force-pushed
the
development
branch
from
1da5deb to
df0b34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm not entirely sure if i'm missing some of the functions here and here, if that's so let me know!