Fix pyright errors in arcade.gl - #1767
Conversation
|
Oh, ok you should make it a draft then. (unless there is something I don't understand) |
|
The gl stuff looks perfectly reasonable 👍 |
This reverts commit bfee79a.
d48147a to
8a6d8a3
Compare
|
I rebased yesterday, but there are still one or two mypy errors I need to understand and fix before this can merge. I'll solicit a review after I've fixed them. |
|
@einarf I need some help understanding some of the gl types. arcade/arcade/gl/vertex_array.py Lines 195 to 196 in 889772d I get a typecheck diagnostic Argument 1 to "gl_name" has incompatible type "Optional[int]"; expected "int"This is because prog_attr.gl_type is Optional[int]
Is that correct, should
Lines 394 to 401 in 889772d and here: Lines 311 to 314 in 889772d For the latter, Lines 196 to 220 in 889772d |
Followup to #1751. Will need a rebase after #1751 gets squashed. Requesting a review from @einarf , but no rush, I know you're slowly getting back into things.