Correct coordinate calculation for rectangle#1741
Merged
Merged
Conversation
Member
|
Looks like it didn't pass tests? Please research if you could. |
gran4
suggested changes
Apr 30, 2023
Contributor
Author
|
I will look at the test after the end of Ludumdare, |
- scale the rectangle as anyother coordinate - use self.tiled_map.map_size.height * self.tiled_map.tile_size[1] to offset the y coordinate, otherwise they are negative.
Contributor
Author
|
I've updated the patch, and it now pass all the test. Thanks. |
gran4
approved these changes
May 3, 2023
Some computation are made to translate the coordinate système of tiled to the one of arcade. Those 3 new test check they are ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new computation
Fix #1740