Add / fix __all__ problems discovered by mypy and pyright #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspotcode
changed the title
cspotcode
force-pushed
the
cspotcode_add__all__to_all
branch
from
c4fb49b to
49b1578
Compare
cspotcode
force-pushed
the
cspotcode_add__all__to_all
branch
from
49b1578 to
1fa8387
Compare
pushfoo
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
This looks good. I cloned it locally and merged development into it. Everything still passes.
The __all__ in arcade.gui.widgetes.layout is a little long, but I think it's acceptable for now. We can split it into a multi-line version if more layouts get added.
To be honest, I'm so accustomed to a formatter modifying that stuff automatically, I didn't even think about. I made it multiline |
pushfoo
requested changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #1390
Building off the great work in #1681, and using a combination of mypy and pyright, I discovered a few more missing or broken
__all__declarations.This PR's diff is misleading because it builds off of #1681. The diff will shrink after #1681 merges. These are the relevant changes:
https://github.com/cspotcode/arcade/compare/ae863d71159491b8726c5b1e1497fcf6085f3fa3..cspotcode_add__all__to_all
pyright's reportUnsupportedDunderAll tells us if
__all__refers to something that doesn't exist, for example"Texture"instead of"Texture2d"mypy's attr-defined tells us when something is imported yet the importee does not declare it in
__all__