Skip to content

Clarify & speed up basic views tutorial #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Mar 24, 2023

  • Reduce coin count from 50 to 25 (focus is on views, not the game)

Copy link
Contributor

@Ibrahim2750mi Ibrahim2750mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@einarf einarf requested a review from pvcraven March 24, 2023 21:58
@pushfoo
Copy link
Member Author

pushfoo commented Mar 24, 2023

@pvcraven for context, the direction I'm leaning towards for this would be to move this under a "Screens & Menus with Views" headings akin to the shaders index we currently have.

I may want to have #1608 expand on it, but I'm not sure yet. What I am sure of is that 50 coins takes far too long to play through for a tutorial which is about the screens, not the gameplay.

@pushfoo
Copy link
Member Author

pushfoo commented Mar 28, 2023

@pvcraven any objections to replacing code like this:

sprite.center_x = 10
sprite.center_y = 10

with more efficient code which doesn't update the SpriteList twice?

sprite.position = 10, 10

Also sorry for the close / re-open. I had a touchpad issue.

@pushfoo pushfoo closed this Mar 28, 2023
@pushfoo pushfoo reopened this Mar 28, 2023
@pvcraven
Copy link
Member

pvcraven commented Apr 1, 2023

@pvcraven any objections to replacing code like this:

sprite.center_x = 10
sprite.center_y = 10

with a more efficient code which doesn't update the SpriteList twice?

sprite.position = 10, 10

No. Some examples that are super-basic I avoid that because students might not be introduced to tuples yet. But by the time they use screens, shouldn't be an issue.

@pushfoo pushfoo force-pushed the views_tutorial_improvements branch from ea311c4 to c4185bf Compare April 1, 2023 01:43
@pvcraven pvcraven merged commit 61565a0 into pythonarcade:development Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants