-
Notifications
You must be signed in to change notification settings - Fork 343
Tutorial for Menu #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for Menu #1608
Conversation
Will make another pr for it
Will make another pr for this
The UISlider throwing an exception should be fixed now. |
24f58a8
to
5bfe103
Compare
Eruvanos is already fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready? You've got 1/4 tasks but the PR is not in a 'draft' state, so I'm a bit confused. If it is ready to be included, keep it in the current 'ready' state. Otherwise set to 'draft'.
I'm excited to get a tutorial for GUI in, and this looks good.
It is ready 100%, I have added those checkboxes for the people who choose to review just for double checking my stuff. I will tick those if you say so. |
Looks good to me! I didn't merge because you said "Also don't merge now @eruvanos said he will have a look sometime this week." |
I have basically the full day tomorrow, I plan to care about all PRs regarding GUI and finish my left over tasks. |
tl;dr I think this should be simplified and split, but we could do it in subsequent PRs There are multiple concerns mixed together in this PR which I think should be separate:
I think we should consider something like the following steps within the framework:
|
@pushfoo I get your concerns and agree, that we could split up the tutorial even more. Still I merge this and we can improve and split up things afterwards, if somebody can spend the time to do so. @Ibrahim2750mi Thank you for your work! |
Please Review
What to review:
Also currently waiting for @eruvanos to propose a fix for UIDropdown 🙏🏽 inmenu_05.py
.The code errors now when operation the UISlider, its because of a bug/wrong code style.