Expand protocol allowlist to match CPythons#676
Expand protocol allowlist to match CPythons#676JanEricNitschke wants to merge 5 commits intopython:mainfrom
Conversation
|
Thanks! Could you add a changelog entry and address the CI failures? |
|
With the test failure in 3.13 there is actually a decision that would have to be made that i only noticed now. Because 3.14 added But i guess it makes the most sense to also backport the os.PathLike, so ill adjust the PR unless you disagree or think this needs more discussion. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 97.36% 97.37%
=======================================
Files 3 3
Lines 7680 7685 +5
=======================================
+ Hits 7478 7483 +5
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Yes, we should backport the PathLike support to 3.14 and adjust the version check accordingly. |
Also backport these to 3.13
Discovered by running the CPython 3.12 test_typing.py over typing_extensions.
https://github.com/JanEricNitschke/typing_extensions/actions/runs/17633620675/job/50105726688#step:7:38
Originally failing test: https://github.com/python/cpython/blob/3.12/Lib/test/test_typing.py#L4047
Current situation in 3.14: https://github.com/python/cpython/blob/3.14/Lib/test/test_typing.py#L4373
And the current allow list: https://github.com/python/cpython/blob/main/Lib/typing.py#L1894