Skip to content

Improve SQLAlchemy type aliases #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

Improve SQLAlchemy type aliases #8252

merged 2 commits into from
Jul 7, 2022

Conversation

AlexWaygood
Copy link
Member

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While all the type aliases imported from mypy exist at runtime, I don't think they need to be re-exported from sqlalchemy.ext.mypy.

@srittau srittau merged commit 850bc78 into master Jul 7, 2022
@srittau srittau deleted the sqlalchemy-aliases branch July 7, 2022 12:11
@AlexWaygood
Copy link
Member Author

While all the type aliases imported from mypy exist at runtime, I don't think they need to be re-exported from sqlalchemy.ext.mypy.

My thoughts too.

@AlexWaygood AlexWaygood mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @srittau