Remove Python 2 branches from Python 3 stubs #5460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a few missed version_info checks from @python2
|
I did this too, in #5458 (edited, linked wrong pr initially). I'll merge our changes together and see whether we did any things differently. |
|
Superseded by #5461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few missed version_info checks from @python2
I did not do anything but remove branches and version checks and in a few instances move imports to the top. For example, there are a few now useless type aliases, but I left them in so this PR stays only about version checks.
Version checks in stdlib are now much easier to grep, since they now only compare against
(3, 7)and up.