Skip to content

Try to fix comment permissions #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2021
Merged

Try to fix comment permissions #5452

merged 2 commits into from
May 14, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 14, 2021

No description provided.

@Akuli
Copy link
Collaborator

Akuli commented May 14, 2021

I think I didn't catch this while testing it, because I used echo lol > diff.txt to avoid waiting for mypy_primer to run.

I guess the global permissions: is no longer necessary. Should we delete it here or in a separate PR?

We will also port this fix to mypy

@srittau
Copy link
Collaborator Author

srittau commented May 14, 2021

Good call on the permissions. I moved them into the main primer job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants