[stdlib] Deprecate old functions#14553
Merged
AlexWaygood merged 8 commits intopython:mainfrom Aug 10, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Aug 10, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, this is great! I really like that you took care to only add @deprecated for the Python versions where APIs actually caused a deprecation warning to be emitted at runtime. Just some nits about error messages:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Aug 10, 2025
Contributor
Author
|
Thank you for review |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next deprecations were found using grep
version_info <and only if somewhere in docs or source code it was said that it was deprecated, I would add the@deprecated:tkintersplit() method cpython#28237PS: I just want to clarify that I’m not aiming to mark every deprecated function, only the ones that seem most obvious. Also, for functions deprecated since 3.10, I don’t feel that adding sys.version_info check is necessary.