Skip to content

Conversation

@hunterhogan
Copy link
Contributor

@hunterhogan hunterhogan commented Jun 18, 2025

Set the default value of name to None in the MatchStar class constructor.

Issue #14297

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit ca543bf into python:main Jun 18, 2025
64 checks passed
@hunterhogan hunterhogan deleted the astMatchStar branch June 18, 2025 04:26
@srittau
Copy link
Collaborator

srittau commented Jun 18, 2025

For reference: For simple bug fixes like this we don't need an issue in typeshed. Just sending a PR usually speaks for itself.

@hunterhogan
Copy link
Contributor Author

For reference: For simple bug fixes like this we don't need an issue in typeshed. Just sending a PR usually speaks for itself.

Thank you for the vote of confidence.

Sometimes, I think I found a bug. #13878 Sometimes, I have found a bug. #14103 Sometimes, it is obviously a bug. #14241 Sometimes, there is a good reason for the discrepancy.

I am aggravating many people, and I am ashamed.

@Akuli
Copy link
Collaborator

Akuli commented Jun 18, 2025

I am aggravating many people, and I am ashamed.

Don't be ashamed :)

In case nobody has told it to you explicitly yet, it is very normal to make mistakes and be wrong in software development. For example, sometimes a bug report turns out to not actually be a bug. That's totally fine, and actually expected.

@AlexWaygood
Copy link
Member

+1 to everything Akuli said. You never stop learning in software development. We're all constantly making mistakes!

@hunterhogan
Copy link
Contributor Author

@Akuli , @srittau , @AlexWaygood, and @brianschubert : thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants