Skip to content

Document policy for future Python versions #12592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Aug 25, 2024

Closes: #12569

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also consider adding an AST-based lint to check_typeshed_structure.py enforcing this (but that doesn't have to be done in this PR). I don't think such a lint would be a good fit for flake8-pyi since it would be enforcing a typeshed-specific policy

@srittau srittau merged commit 7c1378c into python:main Aug 25, 2024
1 check passed
@srittau srittau deleted the stdlib-policy branch August 25, 2024 16:24
@JelleZijlstra
Copy link
Member

We could also consider adding an AST-based lint to check_typeshed_structure.py enforcing this (but that doesn't have to be done in this PR). I don't think such a lint would be a good fit for flake8-pyi since it would be enforcing a typeshed-specific policy

I'd prefer to not add any such lint checks directly to typeshed, and leave those to tools that are good at linting. In flake8-pyi we could add a configuration option like allowed_versions = ["3.8", "3.14"] and make it warn about version checks outside that range, so other projects could set their own policy.

max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When should we start accepting PRs for future Python versions
3 participants