Apply feedback

Author: Viicos

stubs/django-import-export/METADATA.toml

@@ -1,3 +1,6 @@
 version = "3.3.*"
 upstream_repository = "https://github.com/django-import-export/django-import-export"
-requires = ["django-stubs", "tablib"]
+requires = ["django-stubs"]  # Add tablib when typed, and update _Incomplete aliases in stubs
+
+[tool.stubtest]
+skip = true  # Django requires configured settings at runtime

stubs/django-import-export/import_export/admin.pyi

@@ -1,7 +1,8 @@
+from _typeshed import Incomplete
 from collections.abc import Callable
 from logging import Logger
 from typing import Any, TypeVar
-from typing_extensions import deprecated
+from typing_extensions import TypeAlias, deprecated
 
 from django.contrib import admin
 from django.contrib.admin.helpers import ActionForm
@@ -12,13 +13,13 @@ from django.http.request import HttpRequest
 from django.http.response import HttpResponse
 from django.template.response import TemplateResponse
 from django.urls import URLPattern
-from tablib import Dataset  # type: ignore[import-untyped]
 
 from .formats.base_formats import Format
 from .mixins import BaseExportMixin, BaseImportMixin
 from .results import Result
 from .tmp_storages import BaseStorage
 
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
 logger: Logger
 
 _ModelT = TypeVar("_ModelT", bound=Model)

stubs/django-import-export/import_export/formats/base_formats.pyi

@@ -1,8 +1,8 @@
-from _typeshed import ReadableBuffer
+from _typeshed import Incomplete, ReadableBuffer
 from typing import IO, Any, ClassVar
-from typing_extensions import Self
+from typing_extensions import Self, TypeAlias
 
-from tablib import Dataset  # type: ignore[import-untyped]
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
 
 class Format:
     def get_title(self) -> type[Self]: ...

stubs/django-import-export/import_export/instance_loaders.pyi

@@ -1,11 +1,14 @@
+from _typeshed import Incomplete
 from typing import Any
+from typing_extensions import TypeAlias
 
 from django.db.models import Model, QuerySet
-from tablib import Dataset  # type: ignore[import-untyped]
 
 from .fields import Field
 from .resources import Resource
 
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
+
 class BaseInstanceLoader:
     resource: Resource[Any]
     dataset: Dataset | None

stubs/django-import-export/import_export/mixins.pyi

@@ -1,17 +1,19 @@
-from _typeshed import SupportsGetItem
+from _typeshed import Incomplete, SupportsGetItem
 from logging import Logger
 from typing import Any, Generic, TypeVar
+from typing_extensions import TypeAlias
 
 from django.db.models import Model, QuerySet
 from django.forms import BaseForm, Form
 from django.http.request import HttpRequest
 from django.http.response import HttpResponse
 from django.views.generic.edit import FormView
-from tablib import Dataset  # type: ignore[import-untyped]
 
 from .formats.base_formats import Format
 from .resources import Resource
 
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
+
 logger: Logger
 
 _ModelT = TypeVar("_ModelT", bound=Model)

stubs/django-import-export/import_export/resources.pyi

@@ -1,19 +1,20 @@
+from _typeshed import Incomplete
 from collections import OrderedDict
 from collections.abc import Iterator, Sequence
 from functools import partial
 from logging import Logger
 from typing import Any, ClassVar, Generic, Literal, NoReturn, TypeVar, overload
-from typing_extensions import deprecated
+from typing_extensions import TypeAlias, deprecated
 
 from django.db.models import Field as DjangoField, ForeignObjectRel, Model, QuerySet
 from django.utils.safestring import SafeString
-from tablib import Dataset  # type: ignore[import-untyped]
 
 from .fields import Field
 from .instance_loaders import BaseInstanceLoader
 from .results import Error, Result, RowResult
 from .widgets import ForeignKeyWidget, ManyToManyWidget, Widget
 
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
 logger: Logger
 
 @overload

stubs/django-import-export/import_export/results.pyi

@@ -1,11 +1,13 @@
+from _typeshed import Incomplete
 from collections import OrderedDict
 from collections.abc import Iterator
 from typing import Any, ClassVar, Literal
 from typing_extensions import TypeAlias
 
 from django.core.exceptions import ValidationError
 from django.db.models import Model
-from tablib import Dataset  # type: ignore[import-untyped]
+
+Dataset: TypeAlias = Incomplete  # tablib.Dataset
 
 class Error:
     error: Exception