Dark mode: add class to invert image brightness#128
Merged
pradyunsg merged 1 commit intopython:mainfrom Apr 30, 2023
Merged
Conversation
This was referenced Apr 28, 2023
Merged
Merged
pradyunsg
approved these changes
Apr 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For python/cpython#103960.
Re: #44 (comment).
Add a class to invert image brightness (but not contrast), similar to how we handled it for the PEPs repo: python/peps#2409 and python/peps#2949.
We can then add this class to images like this:
Which changes this:
Details
Into:
Details
And light mode remains unchanged:
Details
This can be merged before or after python/cpython#103983.