Tweak PEP references to work on topic sub-index pages #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
pradyunsg
force-pushed
the
fix-topic-page-pep-references
branch
from
6ad7c5d to
a201663
Compare
This was a concern/usability point rasised during the implementation of the new rendering system, and so I'd like to keep the functionality. A |
|
How about fixing that in a follow up? I'm inclined to suggest that having working links on peps.python.org is more important than local builds with direct file system usage, especially since local builds have a workaround. :) |
|
Agree with @pradyunsg, I'd rather fix the live links first. We can come up with a solution that works better for local builds later. |
carljm
added a commit
to carljm/peps
that referenced
this pull request
Jun 27, 2022
* main: (47 commits) PEP 668: Address feedback and mark as accepted (python#2673) PEP-0691 Gramatical changes + `meta` key description under Project List (python#2677) PEP691: Mark Accepted + Grammar Fixes + Small Fix (python#2674) PEP 691: touch up (python#2668) PEP 650: Withdraw and move to Standards Track (python#2665) PEP 561: Mark as final (python#2663) PEP 660: Mark as Final (python#2664) PEP 615: Fix incorrect RFC link (python#2662) Multiple PEPs: Move Packaging PEPs to Standards Track and mark as Final (python#2657) PEP 671: Since it keeps getting asked about, add a para on deferreds (python#2661) Infra: Tweak PEP references to work on topic sub-index pages (python#2658) PEP 632: Remove `Topic: Packaging` header (python#2656) Infra: Make colour theme cycler button accessible (python#2619) PEP 593: Fix citation references (python#2640) PEP 553: Fix citation references (python#2639) PEP 668: Add PEP-Delegate (python#2654) PEP 693: Python 3.12 Release Schedule (python#2648) Add support for topic indices (python#2579) PEP691: Switch to a List for Project, Address more Feedback (python#2653) PEP 671: Add section on evaluation order (python#2652) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2655
Not sure how strongly people care about being able to reach the other PEPs from the filesystem HTML files opened as-is, since that'd be broken with this. On the other hand, viewing the files from an HTTP server run with
python -m http.server buildworks still -- and so does the preview rendered by RTD + URLs that would be used with peps.python.org. :)