PEP 1, 12: Update for adoption of PEP 676, and fix a few related items #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
added
infra
CAM-Gerlach
requested review from
a team,
AA-Turner,
brettcannon,
hugovk,
ncoghlan and
warsaw
as code owners
CAM-Gerlach
requested review from
JelleZijlstra
and removed request for
AA-Turner,
ncoghlan and
warsaw
CAM-Gerlach
changed the title
CAM-Gerlach
changed the title
ncoghlan
approved these changes
Mar 19, 2022
Contributor
|
LGTM, and I think the original acceptance of PEP 676 covers gaining SC approval to update PEP 1. |
JelleZijlstra
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to PR #2399 , which officially moved us over to the new Sphinx-based rendering system proposed in PEP 676.
Updates PEP 1 and 12 to update outdated references to Docutils and the Docutils-based rendering system to refer to Sphinx, ensure the guidance related to the rendering workflow is up to date with current practice, improve the description of and links to help resources. Also, fixes a few minor issues in the Readme introduced by that PR and updates the hardcoded PEP link checker to detect the new URL as well as the old (avoiding it missing them like in #2444, and even I myself not noticing in #2428).