Display list names in Resolution and Discussions-To headers#2361
Merged
JelleZijlstra merged 4 commits intopython:mainfrom Feb 27, 2022
Merged
Display list names in Resolution and Discussions-To headers#2361JelleZijlstra merged 4 commits intopython:mainfrom
JelleZijlstra merged 4 commits intopython:mainfrom
Conversation
AA-Turner
requested review from
a team,
1st1,
JelleZijlstra,
Mariatta,
abalkin,
ambv,
brandtbucher,
brettcannon,
dstufft,
gvanrossum,
ilevkivskyi,
larryhastings,
lysnikolaou,
mitsuhiko,
ncoghlan,
njsmith,
pablogsal,
rbtcollins and
tim-one
as code owners
AA-Turner
removed request for
1st1,
abalkin,
ambv,
brettcannon,
dstufft,
mitsuhiko,
njsmith and
rbtcollins
AA-Turner
removed request for
JelleZijlstra,
Mariatta,
brandtbucher,
gvanrossum,
ilevkivskyi,
larryhastings,
lysnikolaou,
ncoghlan,
pablogsal and
tim-one
brettcannon
approved these changes
Feb 25, 2022
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
I didn't review the code changes, but the PEP changes LGTM.
CAM-Gerlach
reviewed
Feb 25, 2022
Member
There was a problem hiding this comment.
Thanks for your diligent work here; this overall looks excellent and is a significant improvement (over both of our original proposals, and the previous status quo). I checked it on a variety of PEPs with different outputs, and it all looks good, with the exception of two formatting concerns, both of which actually simplify the current code.
JelleZijlstra
requested changes
Feb 26, 2022
CAM-Gerlach
approved these changes
Feb 27, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM, thanks @AA-Turner for this great improvement.
JelleZijlstra
approved these changes
Feb 27, 2022
This was referenced Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #2351, this "prettifies" thread links by extracting the list name for display. I also included Resolution as it seemed odd to normalise one but not the other.
As part of this I also normalised all the mailing list values in Discussions-To (first commit) -- this is not strictly essential but is on the "would be nice" list.
A