Fix accessing unannotated implicit class methods #7739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Thanks for the quick fix!
@msullivan Is this important enough to warrant a bugfix release?
mypy/typeops.py
Outdated
| @@ -428,6 +430,11 @@ def callable_type(fdef: FuncItem, fallback: Instance, | |||
| column=fdef.column, | |||
| implicit=True, | |||
| ) | |||
| if no_self and typ.arg_types: | |||
| typ = typ.copy_modified(arg_types=typ.arg_types[1:], | |||
There was a problem hiding this comment.
Can we use bind_self here?
There was a problem hiding this comment.
At first look it seemed to me bind_self may not work, but now it looks OK to add it in the caller, I will now try to do this. Even if we will discover it doesn't work sometimes, we just need to fix it so it works with unannotated methods.
|
I'm going to wait another day, see if anything else shakes out, and make a call then. |
ilevkivskyi
added a commit
that referenced
this pull request
Oct 21, 2019
This PR fixes an obvious typo (currently `is_classmethod` is not passed to a nested call). I noticed this while working on #7739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7735
The fix is quite straightforward, this was not triggered before because all common cases go trough other code paths.