Add specific message for type errors on dict displays #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Apr 3, 2017
| name = callee.name[1:-1] | ||
| n -= 1 | ||
| key_type, value_type = cast(TupleType, arg_type).items | ||
| msg = '{} entry {} has incompatible type {}: {}'.format( |
There was a problem hiding this comment.
Maybe use item instead of entry, similar to the naming of the items() method?
There was a problem hiding this comment.
I've seen "entry" used for dictionaries (example: https://docs.python.org/3/reference/expressions.html#dictionary-displays) quite often; item too but it's more ambiguous (it's also used for lists). I don't mind changing it to avoid bikeshedding if you still prefer it.
There was a problem hiding this comment.
Okay, entry seems official enough so let's keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #304, #1183, and #2538