Some cleanup in partial plugin #17423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Diff from mypy_primer, showing the effect of this PR on open source code: jax (https://github.com/google/jax)
- jax/_src/nn/functions.py:585: error: Argument 1 to "custom_jvp" has incompatible type "Callable[[Array | Any | Any | Any | bool | int | float | complex, int | tuple[int, ...] | None, Array | Any | Any | Any | bool | int | float | complex | None, Array | Any | Any | Any | bool | int | float | complex | None], Array]"; expected "Callable[..., Never]" [arg-type]
- jax/_src/scipy/special.py:1059: error: Argument 1 to "custom_jvp" has incompatible type "Callable[[Array | Any | Any | Any | bool | int | float | complex, int], Array]"; expected "Callable[..., Never]" [arg-type]
- jax/experimental/rnn.py:245: error: Argument 1 to "custom_vjp" has incompatible type "Callable[[Array, Array, Array, Array, Array, int, int, int, float, bool, str | Precision | tuple[str, str] | tuple[Precision, Precision] | None], tuple[Array, Array, Array]]"; expected "Callable[..., Never]" [arg-type]
+ jax/_src/scipy/stats/norm.py:161: error: Redundant cast to "Array" [redundant-cast]
- jax/_src/cudnn/fused_attention_stablehlo.py:1000: error: Need type annotation for "output" [var-annotated]
- jax/experimental/pallas/ops/tpu/flash_attention.py:1579: error: Need type annotation for "res" [var-annotated]
pwndbg (https://github.com/pwndbg/pwndbg)
- pwndbg/gdblib/events.py:160: error: Need type annotation for "before_prompt" [var-annotated]
|
hauntsaninja
approved these changes
Jun 22, 2024
|
Yes, I also have #17424, and maybe one more. |
hauntsaninja
added a commit
that referenced
this pull request
Jul 1, 2024
- Fixes another crash case / type inference in that case - Fix a false positive when calling the partially applied function with kwargs - TypeTraverse / comment / daemon test follow up ilevkivskyi mentioned on the original PR See also #17423
hauntsaninja
added a commit
that referenced
this pull request
Jul 1, 2024
- Fixes another crash case / type inference in that case - Fix a false positive when calling the partially applied function with kwargs - TypeTraverse / comment / daemon test follow up ilevkivskyi mentioned on the original PR See also #17423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17405
Apart from fixing the crash I fix two obvious bugs I noticed while making this PR.
cc @hauntsaninja