Preserve file order of messages during successive daemon runs - #13780
Merged
Conversation
This fixes an annoyance where the messages got reshuffled between daemon runs. Also if there are messages from files that didn't generate messages during the previous run, move them towards the end to make them more visible. Fix #13141.
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Sep 30, 2022
| msg2, | ||
| msg1, | ||
| msg3, | ||
| ] |
Member
There was a problem hiding this comment.
Add a test where there are more files in the new errors (unless I missed it)?
Collaborator
Author
There was a problem hiding this comment.
Added a test case and fixed an issue related to this.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an annoyance where the messages got reshuffled between daemon runs.
Also if there are messages from files that didn't generate messages during the previous run, move them towards the end to make them more visible.
The implementation is a bit messy since we only have a list of formatted lines where it's most natural to sort the messages, but individual messages can be split across multiple lines.
Fix #13141.