Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site package on MYPYPATH check #13223

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

hauntsaninja
Copy link
Collaborator

This was a regression in 0.971

Fixes #13214

This was a regression in 0.971

Fixes python#13214
@hauntsaninja
Copy link
Collaborator Author

No unit test, since it's a little bit of a pain, but tested manually with:

mkdir repro
cd repro

mkdir stubs
echo 'x = 5' > stubs/mod.py

echo 'from setuptools import setup; setup()' > setup.py
echo 'from mod import x' > proj.py

python3 -m venv env
source env/bin/activate

python3 -m pip install -e .
python3 -m pip install -e ~/dev/mypy

MYPYPATH=$(pwd)/stubs python -m mypy proj.py

cd ..
rm -rf repro

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@ilevkivskyi ilevkivskyi merged commit 2a519c0 into python:master Jul 25, 2022
@hauntsaninja hauntsaninja deleted the site-package-check branch July 25, 2022 18:18
@vfazio
Copy link

vfazio commented Jul 26, 2022

Any chance this will drive a minor version bump?

@hauntsaninja
Copy link
Collaborator Author

I don't have the power to make releases, but I mentioned it in #13089 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in-project stubs cause mypy to bail in 0.971
3 participants