Skip to content

Fix crash when using decorator in class scope #12724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dzcode
Copy link
Contributor

@dzcode dzcode commented May 3, 2022

Description

Fixes #12474

Fix INTERNAL_ERROR when using a decorated function within class scope.

Test Plan

Add unit test

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Run unit tests

@dzcode dzcode changed the title Fixes: Issue 12474 - Fix crash when using decorator in class scope Fix crash when using decorator in class scope May 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@hauntsaninja hauntsaninja merged commit 4746519 into python:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INTERNAL ERROR on class scoped import of a decorated function
2 participants