Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes __slots__ regression in 0.930, refs #11821 #11824

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Fixes __slots__ regression in 0.930, refs #11821 #11824

merged 3 commits into from
Dec 30, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 22, 2021

Any other possible cases that I've missed?

Closes #11821
Closes #11827

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (both for this and the original feature)

I got a little confused by the type vars until I noticed the quotes. testSlotsDefinitionWithTwoPasses4 also makes it quite obvious what the issue is.

@hauntsaninja hauntsaninja merged commit ee37502 into python:master Dec 30, 2021
JukkaL pushed a commit that referenced this pull request Jan 5, 2022
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False error for dataclass slots when class is referenced earlier Regression in 0.930 - Slots
2 participants