Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds @enum.unique decorator support #11249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds @enum.unique decorator support #11249

wants to merge 4 commits into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 2, 2021

Right now it uses ast to tell which values are non unique.
It does not support function that return Literal values, Final constants, etc.
But, it works!

After #11247 is merged, I am going to add the support for Literal and Final values.

Refs #11248

Closes #10858

@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

sobolevn commented Nov 3, 2021

Rebased!

cc @JukkaL

@sobolevn sobolevn mentioned this pull request Dec 11, 2021
Open
@hauntsaninja hauntsaninja reopened this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum plugin should support unique check where possible
2 participants
@sobolevn @hauntsaninja