[mypyc] Small documentation updates #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjohns
commented
Mar 8, 2021
| @@ -38,7 +38,7 @@ can be assigned to (similar to using ``__slots__``):: | |||
| def method(self) -> None: | |||
| self.z = "x" | |||
|
|
|||
| o = Cls() | |||
| o = Cls(0) | |||
There was a problem hiding this comment.
This allowed this piece of code to compile for me (__init__ is expecting one non-self argument).
thomasjohns
commented
Mar 8, 2021
| @@ -6,6 +6,7 @@ __pycache__ | |||
| /env*/ | |||
| docs/build/ | |||
| docs/source/_build | |||
| mypyc/doc/_build | |||
There was a problem hiding this comment.
This was the default directory generated from running make html inside mypyc/doc/.
JukkaL
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few updates/fixes after a read through the mypyc docs.
For the corresponding primitive method updates, see:
str.replace: [mypyc] Support str.replace #10088dict.copy: [mypyc] Implement dict copy primitive #9721dict.clear: [mypyc] Implement dict clear primitive #9724