Fix test_find_sources when run under site-packages #10075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing during wheel builds because we run the tests after installation (under `site-packages`), and this confused the module search logic. Hard code the paths to make this work in any install location.
ilevkivskyi
approved these changes
Feb 11, 2021
JelleZijlstra
approved these changes
Feb 11, 2021
JukkaL
added a commit
that referenced
this pull request
Feb 11, 2021
This was failing during wheel builds because we run the tests after installation (under `site-packages`), and this confused the module search logic. Hard code the paths to make this work in any install location.
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing during wheel builds because we run the tests after
installation (under
site-packages), and this confused the modulesearch logic. Use a temp directory instead.