Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversible/Sequence have incompatible variance #916

Closed
jhance opened this issue Oct 12, 2015 · 2 comments
Closed

Reversible/Sequence have incompatible variance #916

jhance opened this issue Oct 12, 2015 · 2 comments
Labels
bug mypy got something wrong

Comments

@jhance
Copy link
Collaborator

jhance commented Oct 12, 2015

In our typing stuff, Sequence subclasses Reversible. This doesn't happen in the PEP 484 typing repository.

Sequence is covariant on its type variable and Reversible is not.
@JukkaL JukkaL added the bug mypy got something wrong label Oct 13, 2015
@JukkaL
Copy link
Collaborator

JukkaL commented Oct 13, 2015

We should conform to PEP 484.

@jhance
Copy link
Collaborator Author

jhance commented Oct 18, 2015

Closing because this is really a problem in typeshed

@jhance jhance closed this as completed Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhance @JukkaL