Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental mode confusion about deleted module imported with import from #7277

Open
msullivan opened this issue Jul 31, 2019 · 0 comments
Open

Comments

@msullivan
Copy link
Collaborator

The following test produces no errors:

[case testDeletedModuleFromImport]
# flags: --ignore-missing-imports
from a import b
[file a/__init__.py]
[file a/b.py]
[delete a/b.py.2]

while it would if not incremental, saying that a has no attribute b.

The issue here is that the cache indicates that a.b is a module, and so we think of it as a missing module import, which we ignore, and not a missing attribute import, which we report.

This caused a divergence between incremental and full modes that broke our build.

(This seems similar to #4698 but I don't /think/ it is actually related.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants