Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cache performance in fine-grained incremental mode #5002

Open
ilevkivskyi opened this issue May 3, 2018 · 1 comment
Open

Comments

@ilevkivskyi
Copy link
Member

We don't have good tests for end-to-end cache performance. It would be good to add tests that check that cache files written in a normal run with --cache-fine-grained are then successfully loaded in a subsequent daemon cold start. The emphasis here is on end-to-end, we have tests that use cache but they don't exactly emulate what happens "in real world". An additional argument for this is that code in build.py responsible for cache loading is quite complicated, so it is better to be sure that we don't break it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants