Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained: Make sure all nodes in symbol tables have fullnames if needed #4724

Open
JukkaL opened this issue Mar 13, 2018 · 2 comments
Open

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Mar 13, 2018

If a Node object stored in a symbol table doesn't have a full name defined (i.e. it's None) we can't refresh that node reliably since we have to check that the symbol table node doesn't hold a alias to something else, and we do this comparison using the full name.

If the node can't be refreshed (e.g. variables), a missing full name might still be a problem for AST diff, for example.

@ilevkivskyi
Copy link
Member

I have encountered this problem few times when working on strict optional, so I am a big +1 on this. But how is it going to be implemented? If we add asserts before serialization, them this will lead to crashes in short term.

@msullivan
Copy link
Collaborator

Have we seen problems with this recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants