Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for interactions between plugins and forward references #4364

Open
ilevkivskyi opened this issue Dec 14, 2017 · 1 comment
Open

Add tests for interactions between plugins and forward references #4364

ilevkivskyi opened this issue Dec 14, 2017 · 1 comment
Labels
priority-1-normal topic-plugins The plugin API and ideas for new plugins topic-tests

Comments

@ilevkivskyi
Copy link
Member

I think it makes sense to check interaction of every plugin (especially those that are called during semantic analysis and/or touch tuple_type, typeddict_type etc.) with forward references.
@ilevkivskyi ilevkivskyi added priority-1-normal topic-plugins The plugin API and ideas for new plugins labels Dec 14, 2017
@ilevkivskyi ilevkivskyi mentioned this issue Dec 14, 2017
Merged
@ilevkivskyi
Copy link
Member Author

This would prevent #5864, so the fix for latter should include extensive tests (to fix also this issue).

@JelleZijlstra JelleZijlstra changed the title Add tests for interactions between plugins and forward refernces Add tests for interactions between plugins and forward references Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal topic-plugins The plugin API and ideas for new plugins topic-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilevkivskyi